Ondřej Svoboda has posted comments on this change.

Change subject: network: relax a condition so DUID can be inherited again
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54130/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 515:         return
Line 516: 
Line 517:     for devices in (_netinfo.nics, _netinfo.bondings, _netinfo.vlans):
Line 518:         port = devices.get(bridge.port.name)
Line 519:         if port:
> the condition would be clearer as
Done
Line 520:             bridge.duid_source = bridge.port.name
Line 521:             break
Line 522: 
Line 523: 


-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com>
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to