Edward Haas has posted comments on this change. Change subject: net: IP address hostport split tool ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/54312/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-03-03 17:50:20 +0200 Line 4: Commit: Edward Haas <[email protected]> Line 5: CommitDate: 2016-03-03 18:21:01 +0200 Line 6: Line 7: net: IP address hostport split tool > hostport is correct only for the networking case, but we need a more generi We are providing a networking 'tool', if something else is needed, it does not fit here. hostport is mentioned here: http://www.ietf.org/rfc/rfc3986.txt , we use it in a networking context in several places. It's not perfect, but it is well known to follow the *:* format. I think you can use it for host:/path as well. If you prefer not to use it from a networking tool, the implementation here will still remain the same for the port part. But I guess I'll have to change the comment. Line 8: Line 9: vdsm.network.ip.address.hostport_split is provided to decode hostport Line 10: and nfs mount path. Line 11: Both use the following structure: host:rest, where 'rest' is either a -- To view, visit https://gerrit.ovirt.org/54312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib246c78987f9707674a1966df91120d4189b41fc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
