Petr Horáček has posted comments on this change. Change subject: net: netswitch: test implementation ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/54361/2/lib/vdsm/network/netswitch/switches/legacy/configurators/__init__.py File lib/vdsm/network/netswitch/switches/legacy/configurators/__init__.py: > I found that having code in __init__.py can cause problems, but here it see I'm not sure if we should dictate the structure at all. Won't it be sufficient to require module/switch.py and Switch() implementation in that? Line 1: # Copyright 2013-2014 Red Hat, Inc. Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by -- To view, visit https://gerrit.ovirt.org/54361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e4f91da9cf0abd53dd234a10a1a375bd628d67a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
