Nir Soffer has posted comments on this change.

Change subject: health: Warn about delays in monitor threads
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Document unit of max delay "(in seconds)"

https://gerrit.ovirt.org/#/c/52524/1/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 434:         ('health_check_interval', '60',
Line 435:             'Number of seconds to wait between health checks.'),
Line 436: 
Line 437:         ('health_max_delay', '0.5',
Line 438:             'Warn if health checks are delayed longer than this 
interval.'),
> Please add unit of time which is used by this delay.
Will add
Line 439: 
Line 440:     ]),
Line 441: 
Line 442:     # Section: [gluster]


-- 
To view, visit https://gerrit.ovirt.org/52524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a0a1b1a375166a08443673a097706998bbdad57
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to