Francesco Romani has uploaded a new change for review. Change subject: vm: rng: add TODO about schema cleanup ......................................................................
vm: rng: add TODO about schema cleanup The Rng device uses the data Engine sends, documented in schema, in a pretty obscure and confusing way. Once we streamline this, we can unlock further schema cleanup. Add a TODO comment in the code to make sure this is not forgotten. Change-Id: I35b3b135176a04d9ff55c7c6d97fc1dd70ba2120 Signed-off-by: Francesco Romani <[email protected]> --- M vdsm/virt/vmdevices/core.py 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/54506/1 diff --git a/vdsm/virt/vmdevices/core.py b/vdsm/virt/vmdevices/core.py index aef0b2f..b74a10a 100644 --- a/vdsm/virt/vmdevices/core.py +++ b/vdsm/virt/vmdevices/core.py @@ -260,6 +260,11 @@ <backend model='random'>/dev/random</backend> </rng> """ + # TODO: we can simplify both schema and code getting rid + # of either VmRngDeviceType or VmRngDeviceModel. + # libvirt supports only one device type, 'virtio'. + # To do so, we need to add tests and we need to do some code refactoring + # before. rng = self.createXmlElem('rng', None, ['model']) # <rate... /> element -- To view, visit https://gerrit.ovirt.org/54506 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I35b3b135176a04d9ff55c7c6d97fc1dd70ba2120 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
