Dan Kenigsberg has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors ......................................................................
Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/48871/17/lib/vdsm/define.py File lib/vdsm/define.py: Line 39: 'unexpected': exception.UnexpectedError().response(), Line 40: 'unsupFormat': exception.UnsupportedImageFormat().response(), Line 41: 'ticketErr': exception.SpiceTicketError().response(), Line 42: 'nonresp': exception.NonResponsiveGuestAgent().response(), Line 43: # codes 20-35 are reserved for add/delNetwork these comments were justfully placed in exception.py. no need to repeat them here. Line 44: # code 39 was used for: Line 45: # wrongHost - migration destination has an invalid hostname Line 46: 'unavail': exception.ResourceUnavailable().response(), Line 47: 'changeDisk': exception.ChangeDiskFailed().response(), -- To view, visit https://gerrit.ovirt.org/48871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01b736c06414a3af758ad6bdabddb6c25b620756 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
