Ondřej Svoboda has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/54555/5/lib/vdsm/network/configurators/ifcfg.py File lib/vdsm/network/configurators/ifcfg.py: Line 100: self.runningConfig.save() Line 101: self.runningConfig = None Line 102: Line 103: def configureBridge(self, bridge, **opts): Line 104: if bridge.ipv6.requested: > Consistency is preserved: If there is no IPv6 address, IPv6 is disabled.. T By such a rule, non-top level devices that would "naturally" get an IPv6LL address would actually be subjected to disable_ipv6 regardless of (the network's) configuration. If we manually removed a bridge, its host port would not be directly usable for IPv6 without manually re-enabling IPv6. This is bad. I want disable_ipv6 to be consistent in the chain, either disable_ipv6 everything, or nothing. The restoration code does exactly this and I like it. Line 105: enable_ipv6(bridge.name) Line 106: self.configApplier.addBridge(bridge, **opts) Line 107: ifdown(bridge.name) Line 108: if bridge.port: -- To view, visit https://gerrit.ovirt.org/54555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
