Ondřej Svoboda has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/54555/9/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1879: @permutations([[([4], [6])], Line 1880: [([6], [4])], Line 1881: [([4], [4, 6], [4])]]) Line 1882: @cleanupNet Line 1883: def testStaticNetworkConfig(self, ip_reconfigurations): > Aha, maybe I understand now. Do you suggest to extract the inner function a I mean, to extract the inside of the outer function. Line 1884: with dummyIf(1) as nics: Line 1885: nic, = nics Line 1886: IPv4 = dict(nic=nic, bootproto='none', ipaddr=IP_ADDRESS, Line 1887: netmask=IP_MASK, gateway=IP_GATEWAY) -- To view, visit https://gerrit.ovirt.org/54555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
