Ondřej Svoboda has posted comments on this change.
Change subject: bonding: move pre-generated data to /usr/share/vdsm
......................................................................
Patch Set 1:
Edy, yes we are, more or less. I deleted the *.json files from /usr/share/vdsm
and ran testSetupNetworksAddDelBondedNetwork. The test failed with an
"unexpected" exception.
/var/log/vdsm/supervdsm.log reveals:
MainProcess|Thread-19::ERROR::2016-03-29
12:56:28,234::supervdsmServer::95::SuperVdsm.ServerCallback::(wrapper) Error in
setupNetworks
Traceback (most recent call last):
File "/usr/share/vdsm/supervdsmServer", line 93, in wrapper
res = func(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/vdsm/network/api.py", line 226, in
setupNetworks
_setup_networks(networks, bondings, options)
File "/usr/lib/python2.7/site-packages/vdsm/network/api.py", line 246, in
_setup_networks
legacy_switch.validate_network_setup(networks, bondings)
File "/usr/lib/python2.7/site-packages/vdsm/network/legacy_switch.py", line
620, in validate_network_setup
Bond.validateOptions(bondingAttrs['options'])
File "/usr/lib/python2.7/site-packages/vdsm/network/models.py", line 327, in
validateOptions
defaults = bonding.getDefaultBondingOptions(mode)
File "/usr/lib/python2.7/site-packages/vdsm/utils.py", line 465, in __call__
value = self.func(*args)
File "/usr/lib/python2.7/site-packages/vdsm/netinfo/bonding.py", line 136, in
getDefaultBondingOptions
defaults = getAllDefaultBondingOptions()
File "/usr/lib/python2.7/site-packages/vdsm/utils.py", line 465, in __call__
value = self.func(*args)
File "/usr/lib/python2.7/site-packages/vdsm/netinfo/bonding.py", line 170, in
getAllDefaultBondingOptions
with open(BONDING_DEFAULTS) as defaults:
IOError: [Errno 2] No such file or directory:
'/usr/share/vdsm/bonding-defaults.json'
--
To view, visit https://gerrit.ovirt.org/54850
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fda0f46ec0745e157842756884fe9ff33fb8dae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Edward Haas <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
