Martin Betak has posted comments on this change. Change subject: vm: Move saveState() out of constructor ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/53950/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 685: if not acquired: Line 686: self._vmAsyncStartError = response.error('migrateLimit') Line 687: self._vmStartEvent.set() Line 688: return Line 689: > Well, devil's in the details indeed. yes, after some thought I agree that just before vmStartEvent.set() is the safest and most appropriate test. Of course I will need to do some testing before this can be merged. Line 690: self._vmStartEvent.set() Line 691: try: Line 692: self.memCommit() Line 693: with self._ongoingCreations: -- To view, visit https://gerrit.ovirt.org/53950 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb38fdc06bf1a7b881cd64d2af45a93b16c935ea Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
