Nir Soffer has posted comments on this change. Change subject: virt: add device setup and teardown ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/55135/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1685: for con in self._devices[hwclass.CONSOLE]: Line 1686: con.cleanup() Line 1687: Line 1688: def _teardownDevices(self): Line 1689: for dev_objects in self._devices.values(): This is not safe on Python 3 - check if six has a helper that does nothing on 2 and create a list on 3. Line 1690: for dev_object in dev_objects: Line 1691: dev_object.teardown() Line 1692: Line 1693: def _cleanupRecoveryFile(self): Line 1862: for dev_name, dev in self._host_devices(): Line 1863: self.log.debug('Detaching device %s from the host.' % dev_name) Line 1864: dev.detach() Line 1865: Line 1866: for dev_objects in self._devices.values(): Same issue, same fix (six?) Line 1867: for dev_object in dev_objects: Line 1868: dev_object.setup() Line 1869: Line 1870: if self.recovering: -- To view, visit https://gerrit.ovirt.org/55135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
