Idan Shaby has posted comments on this change. Change subject: storagetests: add test for mount.isMounted ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/55180/2/tests/mountTests.py File tests/mountTests.py: Line 305: with fake_mounts(["server:/path " Line 306: "/rhev/data-center/mnt/server:_path " Line 307: "nfs4 defaults 0 0"]): Line 308: self.assertTrue(mount.isMounted( Line 309: "/rhev/data-center/mnt/server:_path")) > Same, use b"..." Why also here? We are not writing this string to a file. Line 310: Line 311: def test_is_not_mounted(self): Line 312: with fake_mounts(["server:/path " Line 313: "/rhev/data-center/mnt/server:_path " -- To view, visit https://gerrit.ovirt.org/55180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
