Yaniv Bronhaim has posted comments on this change.

Change subject: hooks: Relocate hooking (api) module under lib
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/55544/2/Makefile.am
File Makefile.am:

Line 82:        vdsm-tool/vdsm-tool \
Line 83:        $(NULL)
Line 84: 
Line 85: PYFLAKES_BLACKLIST = \
Line 86:        ./vdsm/hooking.py \
can't be that it matched lib/vdsm/hooking.py. it relative to the makefile 
location. it should be vdsm/hooking.py
Line 87:        $(NULL)
Line 88: 
Line 89: 
Line 90: .PHONY: gitignore


-- 
To view, visit https://gerrit.ovirt.org/55544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2e0ed06d5f17885b5892bb8659c52f4542a9d9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Edward Haas <[email protected]>
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to