Artyom Lukianov has posted comments on this change. Change subject: hooks:checkips: add checkips hook ......................................................................
Patch Set 10: (3 comments) https://gerrit.ovirt.org/#/c/54102/10/vdsm.spec.in File vdsm.spec.in: PS10, Line 378: network to IP's > the host to designated IPs Done Line 375: using the QEMU disk image utility. Line 376: Line 377: %package hook-checkips Line 378: Summary: Check connectivity from network to IP's Line 379: Requires: %{name} > require %{name} = %{version}-%{release} Done Line 380: Line 381: %description hook-checkips Line 382: VDSM hook used to check connectivity from network to given IP's Line 383: Line 790: %systemd_post supervdsmd.service Line 791: %systemd_post vdsm-network.service Line 792: %systemd_post mom-vdsm.service Line 793: %systemd_post ksmtuned.service Line 794: %systemd_post vdsm-checkips.service > this must be done in the %post script of the vdsm-hook-checkips sub rpm. th hm I do not sure if what I found is correct, but %systemd_post() { +if [ $1 -eq 1 ] ; then + /bin/systemctl daemon-reload >/dev/null 2>&1 || : \ +fi if just reload systemd daemon I believe what you said is correct for systemd_preun +%systemd_preun() { +if [ $1 -eq 0 ] ; then \ + /bin/systemctl --no-reload disable %1 > /dev/null 2>&1 || : \ + /bin/systemctl stop %1 > /dev/null 2>&1 || : \ +fi but anyway I will move it to post and preun of hook package Line 795: Line 796: # VDSM installs unit files - daemon-reload will refresh systemd Line 797: /bin/systemctl daemon-reload >/dev/null 2>&1 || : Line 798: exit 0 -- To view, visit https://gerrit.ovirt.org/54102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov <[email protected]> Gerrit-Reviewer: Artyom Lukianov <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
