Dan Kenigsberg has posted comments on this change. Change subject: hooks:checkips: add checkips hook ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/54102/12/vdsm_hooks/checkips/checkipsd File vdsm_hooks/checkips/checkipsd: Line 43: ping_cmd = 'ping' if address_type == CHECKIPV4 else 'ping6' Line 44: command = [ Line 45: ping_cmd, Line 46: '-c', '1', Line 47: '-w', str(PING_TIMEOUT), > didn't see you comment regarding -I: it is the responsibility of the user to select a good target host. We should not force the traffic to go via a specific interface. Line 48: address Line 49: ] Line 50: p = subprocess.Popen( Line 51: command, stdout=subprocess.PIPE, stderr=subprocess.PIPE -- To view, visit https://gerrit.ovirt.org/54102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov <[email protected]> Gerrit-Reviewer: Artyom Lukianov <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
