Martin Betak has posted comments on this change. Change subject: migration: Enable lazy setting of incoming/outgoing limits ......................................................................
Patch Set 21: (1 comment) https://gerrit.ovirt.org/#/c/53305/21/vdsm/API.py File vdsm/API.py: PS21, Line 584: int > I do not like this. We expect an int but we cast because we know that it is I really expect that to be int, and I would very much prefer that I didn't need to do the cast here. Honestly I don't know where the problem could reside since I'm reasonably confident that what is passed as an argument from the source is an int. -- To view, visit https://gerrit.ovirt.org/53305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79ab97f15788e4024c94d051e4aade713d760acf Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches