Yaniv Bronhaim has posted comments on this change. Change subject: sd: Remove unused setMetadata ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/45613/6//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-11-15 14:21:54 +0200 Line 6: Line 7: sd: Remove unused setMetadata Line 8: Line 9: All usages of sd setMetadata have been removed. > Which code that was calling setMetadata was removed? can you point me to t no.. tried to find but didn't. maybe it was in rhev3.0 and if so it's not so relevant and important if you want to keep this code it's up to you, just -2 the patch and I'll abandon Line 10: Line 11: Therefore, no longer needed. Line 12: As a result, the backup directory for sd MD Line 13: creation and default values are also removed. -- To view, visit https://gerrit.ovirt.org/45613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0906bfd7dfa128c323aa399810bbd75883618434 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
