Vinzenz Feenstra has posted comments on this change. Change subject: virt: Pass effective guest agent API version during migration ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/53523/3/lib/vdsm/virt/guestagent.py File lib/vdsm/virt/guestagent.py: PS3, Line 119: None > why not just default to _IMPLICIT_API_VERSION_ZERO? because of the usage see vm.py:292 self.conf.pop('guestAgentAPIVersion', None) I'd have to pass there the _IMPLICIT_API_VERSION_ZERO value too -- To view, visit https://gerrit.ovirt.org/53523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e8625ad33f62852baa17cad377ab12065a52dec Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
