Nir Soffer has posted comments on this change. Change subject: virt: fixes for pep8 1.6.x ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/56084/3/vdsm/virt/vmdevices/storage.py File vdsm/virt/vmdevices/storage.py: Line 109: # verify that the cached path is the one used in libvirt. Line 110: # We already hit few times the problem that after a live Line 111: # migration the paths were not in sync anymore (BZ#1059482). Line 112: if (hasattr(d, 'alias') and d.alias == alias and Line 113: d.path != devPath): > Indented like you suggested (which was my first choice btw): This is our current style, enforced by pep 1.5.7. Any reason to change it? Line 114: vm.log.warning('updating drive %s path from %s to %s', Line 115: d.alias, d.path, devPath) Line 116: d.path = devPath Line 117: if d.path == devPath: -- To view, visit https://gerrit.ovirt.org/56084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e06319d0be2cc927ecd3f2bf15f0688bdac11dc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
