Adam Litke has uploaded a new change for review. Change subject: tests: Add test_missing_tags for block storage ......................................................................
tests: Add test_missing_tags for block storage Add a simple test that verifies that volumes with missing tags are not returned by getAllVolumes. Change-Id: Idb789cf146a4a9919e4dc864a0ae744e06510cec Signed-off-by: Adam Litke <[email protected]> --- M tests/Makefile.am M tests/blocksdTests.py A tests/lvs_f9e55e18-67c4-4377-8e39-5833ca422bef.out 3 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/56171/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 86aee59..5020fd9 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -224,6 +224,7 @@ glusterVolumeTasks.xml \ iscsiadm_-m_iface.out \ lvs_3386c6f2-926f-42c4-839c-38287fac8998.out \ + lvs_f9e55e18-67c4-4377-8e39-5833ca422bef.out \ mem_info.out \ toolTests_empty.conf \ toolTests_lconf_ssl.conf \ diff --git a/tests/blocksdTests.py b/tests/blocksdTests.py index 0ba9244..dc522d5 100644 --- a/tests/blocksdTests.py +++ b/tests/blocksdTests.py @@ -84,3 +84,9 @@ sdName = "3386c6f2-926f-42c4-839c-38287fac8998" allVols = blockSD.getAllVolumes(sdName) self.assertEqual(len(allVols), 23) + + @MonkeyPatch(lvm, 'getLV', fakeGetLV) + def test_missing_tags(self): + sdName = "f9e55e18-67c4-4377-8e39-5833ca422bef" + allVols = blockSD.getAllVolumes(sdName) + self.assertEqual(len(allVols), 1) diff --git a/tests/lvs_f9e55e18-67c4-4377-8e39-5833ca422bef.out b/tests/lvs_f9e55e18-67c4-4377-8e39-5833ca422bef.out new file mode 100644 index 0000000..119693a --- /dev/null +++ b/tests/lvs_f9e55e18-67c4-4377-8e39-5833ca422bef.out @@ -0,0 +1,3 @@ + 3oqnyE-86gI-ZcF4-or87-Jt1j-6DdQ-hcGUyl|0574c3f6-3d44-4cc7-98e3-6d90626dd95f|f9e55e18-67c4-4377-8e39-5833ca422bef|-wi-----|2147483648|0|/dev/mapper/1Dafna-rhevm11333889(195)|MD_17,IU_ae863f0d-0f24-41d4-b6ed-333c6634c7dc + c6fE1p-7Uwi-tnPA-CZjt-uxwg-j5aK-bWbs34|0641b528-c72c-45ed-94bc-7090085a0d4b|f9e55e18-67c4-4377-8e39-5833ca422bef|-wi-----|2147483648|0|/dev/mapper/1Dafna-rhevm11333889(259)|PU_00000000-0000-0000-0000-000000000000,MD_21 + ju1mna-9CU4-QwEH-lC74-fOM1-bq2w-rMhTAx|128f0b4a-2ed0-4ea1-84a5-105c6721f4b7|f9e55e18-67c4-4377-8e39-5833ca422bef|-wi-----|2147483648|0|/dev/mapper/1Dafna-rhevm11333889(211)|MD_24,PU_00000000-0000-0000-0000-000000000000,IU_8e6eef9f-457b-4145-ace7-19d35938a80b -- To view, visit https://gerrit.ovirt.org/56171 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idb789cf146a4a9919e4dc864a0ae744e06510cec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
