Michal Skrivanek has posted comments on this change. Change subject: hostdev: ignore scsi devices when retrieving addresses ......................................................................
Patch Set 4: Code-Review+1 (1 comment) please tag as 3.6-only https://gerrit.ovirt.org/#/c/55957/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4092: for x in self._domain.devices.childNodes: Line 4093: # Ignore empty nodes, devices without address and host devices Line 4094: if (x.nodeName == '#text' or Line 4095: not x.getElementsByTagName('address') Line 4096: or x.nodeName == 'hostdev'): I would add a comment that this is actually more of a hack to get it working with custom hooks. It won't stay like that on master Line 4097: continue Line 4098: Line 4099: alias = x.getElementsByTagName('alias')[0].getAttribute('name') Line 4100: if not isKnownDevice(alias): -- To view, visit https://gerrit.ovirt.org/55957 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
