Martin Betak has posted comments on this change. Change subject: migration: Add Dynamic Bounded Semaphores ......................................................................
Patch Set 23: (2 comments) https://gerrit.ovirt.org/#/c/53304/23/tests/vmUtilsTests.py File tests/vmUtilsTests.py: Line 197: self.assertAcquirable(times=added_capacity) Line 198: self.assertNotAcquirable() Line 199: Line 200: def test_bound_decrease_while_acquired(self): Line 201: self.assertAcquirable(times=3) > I guess you can use INITIAL_BOUND also here, right? here the intention was to test decreasing the semaphore but not to total exhaustion so we could still DECREASE and then ACQUIRE, I could add more constants for this but I'm kinda running out of good names for them :-) Line 202: self.sem.bound = 4 Line 203: self.assertAcquirable() Line 204: self.assertNotAcquirable() Line 205: PS23, Line 207: self.assertAcquirable(times=3) > same, you could most likely use INITIAL_BOUND here same motivation as above -- To view, visit https://gerrit.ovirt.org/53304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67376d0bd990f89e0a013887cef1a0cb05fb855d Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
