Michal Skrivanek has posted comments on this change.

Change subject: migration: added logging of more detailed stats
......................................................................


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/55976/14/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 697:                 (self.data_total / Mbytes),
Line 698:                 (self.data_processed / Mbytes),
Line 699:                 (self.data_remaining / Mbytes),
Line 700:                 (self.mem_bps / Mbytes),
Line 701:                 (self.mem_constant / Mbytes),
this is in pages, not megabytes. Can you please amend in your upcoming follow 
up patches somewhere?
Line 702:                 (self.compression_bytes / Mbytes),
Line 703:                 self.dirty_rate,
Line 704:                 self.mem_iteration,
Line 705:             )


-- 
To view, visit https://gerrit.ovirt.org/55976
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0b81c77b62e52190bfb9fe857105389d75d11e4
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Milan Zamazal <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to