Nir Soffer has submitted this change and it was merged.
Change subject: qemuimg: Validate qcow2_compat configuration
......................................................................
qemuimg: Validate qcow2_compat configuration
Validate new qcow2_compat option against a list of approved values, and
raise (new) InvalidConfiguration error if the value is not supported:
InvalidConfiguration: Invalid configuration value: ("Unsupported value
for irs:qcow2_compat: '1.2'",)
This document the ones we accept and help to diagnose configuration
mistakes. We need to maintain this list over time, but it's good for us
to check new compat versions to see if we're ready to allow them to be
used in vdsm storage.
Change-Id: I8e217ec42a803d53403947a5fb140cb51202fbfa
Bug-Url: https://bugzilla.redhat.com/1317850
Signed-off-by: Nir Soffer <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/56110
Reviewed-by: Adam Litke <[email protected]>
Reviewed-by: Freddy Rolland <[email protected]>
Continuous-Integration: Jenkins CI
---
M lib/vdsm/config.py.in
M lib/vdsm/exception.py
M lib/vdsm/qemuimg.py
M tests/qemuimgTests.py
4 files changed, 24 insertions(+), 2 deletions(-)
Approvals:
Nir Soffer: Verified
Adam Litke: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/56110
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e217ec42a803d53403947a5fb140cb51202fbfa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Pavel Gashev <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
