Dan Kenigsberg has posted comments on this change. Change subject: net: OVS driver ......................................................................
Patch Set 19: (1 comment) https://gerrit.ovirt.org/#/c/55958/19/tests/network/ovs_driver_test.py File tests/network/ovs_driver_test.py: PS19, Line 194: TestOvsVsctlCommand.PROCESSED_VSCTL_LIST_BRIDGE_OUTPUT, cmd.result I find this utterly counter-intuitive. You set one value to the property and when you read you get a different object. Can we have an explicit Command.set_raw_result() and then a read-only result() property? -- To view, visit https://gerrit.ovirt.org/55958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic24a9cea8d50e801de12da1c9cfcd2d195aed684 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
