Nir Soffer has posted comments on this change. Change subject: v2v: add support for importing kvm based vms from libvirt ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56459/1/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 158: command = XenCommand(uri, vminfo, job_id, irs) Line 159: elif uri.startswith(_VMWARE_PROTOCOL): Line 160: command = LibvirtCommand(uri, username, password, vminfo, job_id, irs) Line 161: else: Line 162: command = KVMCommand(uri, username, password, vminfo, job_id, irs) > we need to put the ovirt_image_common for 4.0 Sure, but if you want to have your patch in now, you must use soft dependency. Line 163: job = ImportVm(job_id, command) Line 164: job.start() Line 165: _add_job(job_id, job) Line 166: return {'status': doneCode} -- To view, visit https://gerrit.ovirt.org/56459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ddbab700f2e0c54d53ed02ec61477b92c9c7960 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
