Michal Skrivanek has posted comments on this change. Change subject: virt: graphics: enforce spice default mode ......................................................................
Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/56746/3/vdsm/virt/vmdevices/graphics.py File vdsm/virt/vmdevices/graphics.py: Line 132: if not utils.tobool(self.specParams.get('fileTransferEnable', True)): Line 133: filetransfer = vmxml.Element('filetransfer', enable='no') Line 134: graphics.appendChild(filetransfer) Line 135: Line 136: if (self.device == 'spice' and might be worth adding that this can be dropped in 4.1 then as there is no real use-case for enumerating channels and making some of them secure and some of them not. We can drop the list and keep the defaultMode instead Line 137: 'spiceSecureChannels' in self.specParams): Line 138: for chan in self._getSpiceChannels(): Line 139: graphics.appendChildWithArgs('channel', name=chan, Line 140: mode='secure') -- To view, visit https://gerrit.ovirt.org/56746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
