Nir Soffer has posted comments on this change. Change subject: tests: Share failure function ......................................................................
Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/56863/1/tests/storage_volume_artifacts_test.py File tests/storage_volume_artifacts_test.py: Line 32 Line 33 Line 34 Line 35 Line 36 I would put it here: def failure(*args, **kwargs): raise ExpectedFailure Line 47: self.img_id = str(uuid.uuid4()) Line 48: self.vol_id = str(uuid.uuid4()) Line 49: Line 50: def failure(*args, **kwargs): Line 51: raise ExpectedFailure() Why do we need a method? this can be a function in the module. Line 52: Line 53: def test_state_missing(self): Line 54: with self.fake_env() as env: Line 55: artifacts = env.sd_manifest.get_volume_artifacts( -- To view, visit https://gerrit.ovirt.org/56863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9957eed4333d89071b91ff3f842eafd7469c841 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
