Allon Mureinik has posted comments on this change. Change subject: blockSD: Avoid stale lvs ......................................................................
Patch Set 2: (11 comments) https://gerrit.ovirt.org/#/c/56876/2//COMMIT_MSG Commit Message: PS2, Line 9: activate activated PS2, Line 10: in during drop the "in". Also - can you refer to a specific rpm version? This may be a bug we want to report to the iscsi maintainers. PS2, Line 12: slow down significantly lvm commands slow down lvm commands significantly PS2, Line 12: anyone anything PS2, Line 18: a PS2, Line 23: [a|the] PS2, Line 23: produce produces PS2, Line 26: monitor monitoring PS2, Line 28: in both both in PS2, Line 28: deactivate deactivates https://gerrit.ovirt.org/#/c/56876/2/vdsm/storage/lvm.py File vdsm/storage/lvm.py: PS2, Line 657: deactivateUnusedLVs shouldn't this be a private (_) method? -- To view, visit https://gerrit.ovirt.org/56876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7227bb43c2e1ee67a6239956aae48173a27f566e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
