Mark Wu has posted comments on this change.
Change subject: Add an option to create a watchdog device.
......................................................................
Patch Set 10: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 1170: <watchdog model='i6300esb' action='reset'>
Line 1171: <address type='pci' domain='0x0000' bus='0x00' slot='0x05'
Line 1172: function='0x0'/>
Line 1173: </watchdog>
Line 1174: """
also add a test case for it to tests/libvirtvmTests.py ?
Line 1175: m = self.createXmlElem(self.type, None, ['address'])
Line 1176: m.setAttribute('model', self.specParams['model'])
Line 1177: m.setAttribute('action', self.specParams['action'])
Line 1178: return m
Line 2440: dev.specParams['action'] = action
Line 2441: for dev in self.conf['devices']:
Line 2442: if ((dev['type'] == vm.WATCHDOG_DEVICES) and
Line 2443: not "action" in dev['specParams']):
Line 2444: dev['specParams']['action'] = action
you have give a default action 'none' to it, so you needn't fetch it from
libvirt again. so you should remove lines from 2438 to 2444
Line 2445:
Line 2446: def _getUnderlyingVideoDeviceInfo(self):
Line 2447: """
Line 2448: Obtain video devices info from libvirt.
....................................................
File vdsm/vdsmd.init.in
Line 332: set_if_default $qlconf auto_disk_leases 0
Line 333: set_if_default $qlconf require_lease_for_disks 0
Line 334:
Line 335: # Configuring auto dump path
Line 336: set_if_default $qconf auto_dump_path \"$QEMU_DUMP_PATH\"
To make the configuration change apply after upgrading vdsm, you also need bump
"by_vdsm_vers"
Line 337:
Line 338: # Write to all conf files the *end* message of vdsm changes
Line 339: for arg in "${lconf}" "${qconf}" "${ldconf}" "${qlconf}"
Line 340: do
--
To view, visit http://gerrit.ovirt.org/7535
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shao...@linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <m...@linux.vnet.ibm.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Michael Burns <mbu...@redhat.com>
Gerrit-Reviewer: Ryan Harper <ry...@us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shao...@linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shum...@linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <x...@linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
