Nir Soffer has posted comments on this change. Change subject: cdrom: API change: require index ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56805/1/vdsm/API.py File vdsm/API.py: Line 112: def __init__(self, UUID): Line 113: APIBase.__init__(self) Line 114: self._UUID = UUID Line 115: Line 116: def changeCD(self, interface, index, driveSpec): > This was my initial idea, there is one annoying problem though: driveSpec i I'm not sure that we actually support all these. - DriveSpecVolume - vdsm image (PDIV) - DriveSpecGUID - direct lun - DriveSpecPayload - used for cdrom/floppy (not storage) - DriveSpecPath - we have support for vdsm, but engine does not used this (not storage). I think we should remove this. - DriveSpecUUID was never used by engine, and the support in vdsm was removed recently https://gerrit.ovirt.org/56478. This type is removed by https://gerrit.ovirt.org/56992. These parameters should appear in the all the relevant types. We probably should find a better way to specify this without duplicating the schema. Line 117: """ Line 118: Change the CD in the specified VM. Line 119: Line 120: :param vmId: uuid of specific VM. -- To view, visit https://gerrit.ovirt.org/56805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I178c1a02bbad962f9dc9b67bed7691cf170ee896 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
