Edward Haas has posted comments on this change. Change subject: net: add vlan tag to libvirt network def ......................................................................
Patch Set 5: Code-Review-1 Basically the same comments as in https://gerrit.ovirt.org/#/c/56828 There is however a general question that comes to mind: Why do we really need it? When is this value used exactly? In a VM migration or when adding a new VM, we do not really need it.. It can be specified in the domxml of the VM. And we need to do some clever thing over there (with the domxml) due to the graphics listen address. Just raising this because it will be preferred to think of limiting the dependency on the libvirt network DB, so we can remove it completely in the near future. -- To view, visit https://gerrit.ovirt.org/56829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68451e3a4206afdfbb34752cbb73ebacaf1f5563 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
