Edward Haas has posted comments on this change. Change subject: net: don't handle OVS networks in netinfo ......................................................................
Patch Set 2: Code-Review-1 (1 comment) Just a nit https://gerrit.ovirt.org/#/c/56838/2/lib/vdsm/netinfo/__init__.py File lib/vdsm/netinfo/__init__.py: PS2, Line 54: virtualport = xml.find('.//virtualport') : if (virtualport is not None and : virtualport.get('type') == 'openvswitch'): Seems to fit a separate func: _is_openvswitch(xml) It is unfortunate that we cannot filter legacy bridge config directly, leaving us to do a negative filter. It actually belongs to a network libvirt module/package. We should move the existing configurator/libvirt to network/libvirt and add there all network libvirt related handlers. -- To view, visit https://gerrit.ovirt.org/56838 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie733d39efa0fd40a81d3111d55fa19dde9a3c1b6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
