Martin Betak has posted comments on this change.

Change subject: rpc: Add test for 'int' parameters in Bridge
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/56884/2/tests/bridgeTests.py
File tests/bridgeTests.py:

PS2, Line 58: class VM():
> minor: please (always) inherit from object:
Francesco: +9000 but there is this thing -> being the only one in the file :-)


-- 
To view, visit https://gerrit.ovirt.org/56884
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8a2672c53411bed1ac711fffccb543bcfb16024
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to