Yaniv Bronhaim has posted comments on this change. Change subject: [wip] Adding report_stats to host.api ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/56880/2/lib/vdsm/common/host/api.py File lib/vdsm/common/host/api.py: Line 201: report.send('.memory.free', stats['memFree']) Line 202: report.send('.memory.swap_total', stats['swapTotal']) Line 203: report.send('.memory.swap_free', stats['swapFree']) Line 204: report.send('.virt.active_vms', stats['vmActive']) Line 205: report.send('.virt.total_vms', stats['vmCount']) I think this code worth a class. this should be called from sampling each periodic interval (based on host_sample_stats_interval config value). also, getStats can memoized the output if this interval is not passed yet. passing irs, cif, haClient should happen once on startup. -- To view, visit https://gerrit.ovirt.org/56880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23c1141f097f740441d085f99e0bf76eb7f718c9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
