Sahina Bose has posted comments on this change. Change subject: gluster: add gluster heal info verb ......................................................................
Patch Set 7: (4 comments) https://gerrit.ovirt.org/#/c/56738/7/lib/api/vdsmapi-gluster-schema.json File lib/api/vdsmapi-gluster-schema.json: Line 2213: # @status: Status of the brick Line 2214: # Line 2215: # @hostUuid: UUID of the host where the brick is available Line 2216: # Line 2217: # @numberOfEntried: Number of entries to be healed from this brick numberOfEntries Line 2218: # Line 2219: # Since: 4.17.0 Line 2220: ## Line 2221: {'type': 'HealInfo', https://gerrit.ovirt.org/#/c/56738/7/tests/glusterVolumeHealInfo.xml File tests/glusterVolumeHealInfo.xml: Line 8: <numberOfEntries>10</numberOfEntries> Line 9: </brick> Line 10: <brick hostUuid="f0ef3d05-3ef3-411a-af2c-628b0a14278b"> Line 11: <name>ovirt-node-1.test.com:/brick-2</name> Line 12: <status>Connected</status> How about test with one of the bricks Not Connected? I think the numberOfEntries in this case is N/A - we can check if this case is handled. Line 13: <numberOfEntries>0</numberOfEntries> Line 14: </brick> Line 15: <brick hostUuid="f0ef3d05-3ef3-411a-af2c-628b0a14278b"> Line 16: <name>ovirt-node-1.test.com:/brick-3</name> https://gerrit.ovirt.org/#/c/56738/7/vdsm/gluster/cli.py File vdsm/gluster/cli.py: Line 1596: Line 1597: Line 1598: def _parseVolumeHealInfo(tree): Line 1599: """ Line 1600: {'bricks': [{'name': 'server1:/gfs/test-volume_1', can we change this to indicate what return output will have like this: {'name': 'Fully qualified Brick path', 'status' : 'Connected/Not Connected', 'numberOfEntries' : int, 'hostUuid' : uuid} Line 1601: 'status': 'Connected' Line 1602: 'numberOfEntries': 10, Line 1603: 'hostUuid': 'ff4e2cfe-2646-49d7-90dd-0bff530975ed'}, Line 1604: {'name': 'server2:/gfs/test-volume_2', Line 1616: brick['name'] = el.find('name').text Line 1617: brick['status'] = el.find('status').text Line 1618: brick['hostUuid'] = el.get('hostUuid') Line 1619: if brick['status'] == 'Connected': Line 1620: brick['numberOfEntries'] = el.find('numberOfEntries').text else will numberOfEntries be not populated? Line 1621: healInfo['bricks'].append(brick) Line 1622: return healInfo Line 1623: Line 1624: -- To view, visit https://gerrit.ovirt.org/56738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
