Ondřej Svoboda has posted comments on this change. Change subject: ifcfg: ad_actor_system may not be reset to its default value ......................................................................
Patch Set 1: (1 comment) Why I was dealing with it differently (it is semantically different from EXCLUDED_BONDING_ENTRIES). https://gerrit.ovirt.org/#/c/57490/1/lib/vdsm/network/configurators/ifcfg.py File lib/vdsm/network/configurators/ifcfg.py: Line 880: for k, v in default_opts.iteritems(): Line 881: if k != 'mode' and k in current_opts and v != current_opts[k]: Line 882: diff[k] = default_opts[k] Line 883: for k, v in diff.iteritems(): Line 884: if k in ( > did we not have a means to exclude read-only options? This was just a quick hack, to show an option of a different kind (settable, but not resettable) and perhaps (as said in the commit message) find a way to reset it. If I understand the kernel documentation correctly, we could reset it to the bond's MAC address. But we would also have to play tricks not to report it so it probably isn't worth the effort. I'll add ad_actor_system to EXCLUDED_BONDING_ENTRIES and document it properly. It will also have to be removed from bonding-defaults.json. Line 885: # bonding.txt: The value can not be either NULL or Multicast. Line 886: 'ad_actor_system',): Line 887: continue Line 888: with open(netinfo_bonding.BONDING_OPT % (bond_name, k), 'w') as f: -- To view, visit https://gerrit.ovirt.org/57490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f307b64546c3efa73ca202e97ced49eeb9670e9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
