Edward Haas has posted comments on this change. Change subject: net: access network caps via network API ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/57402/7/lib/vdsm/network/api.py File lib/vdsm/network/api.py: PS7, Line 55: caps > It's a bug in caps.py, we should pass it here. I did not upload fix yet. Why can't the super caps be a complement to the non-root caps? If we need to pass the non-root caps here we make a dependency between them and not a 'merge' relation. I saw that in the following patches, it is used for the nics part... and it even changes the non-root caps content. Lets discuss it. -- To view, visit https://gerrit.ovirt.org/57402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfce0d2fe741e89a3ca54b58c9738ce33495ec92 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
