Piotr Kliczewski has posted comments on this change. Change subject: events: introduction of schema ......................................................................
Patch Set 29: (1 comment) https://gerrit.ovirt.org/#/c/54754/29/lib/api/vdsmapi.py File lib/api/vdsmapi.py: Line 317: try: Line 318: # do to issue with typing we are not able to find unknown params Line 319: for param in self.get_event_params(sub_id): Line 320: name = param.get('name') Line 321: if name == 'no_name': > the girl has no name? It is Arya Stark :D Line 322: for key, value in six.iteritems(args): Line 323: if key == "notify_time": Line 324: continue Line 325: self._verify_type(param, {key: value}, sub_id) -- To view, visit https://gerrit.ovirt.org/54754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43a9f1852b1459a2e905244049507704f0187201 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
