Eli Mesika has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/57620/5/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py: Line 92: @utils.memoized Line 93: def _release_name(): Line 94: if os.path.exists('/etc/rhev-hypervisor-release'): Line 95: return OSName.RHEVH Line 96: elif os.path.exists('/etc/os-release'): > /etc/os-release is a generic file present on all recent distributions. It d Done Line 97: return OSName.OVIRT_NGN Line 98: elif glob.glob('/etc/ovirt-node-*-release'): Line 99: return OSName.OVIRT Line 100: elif os.path.exists('/etc/fedora-release'): Line 147: osname = _release_name() Line 148: try: Line 149: if osname == OSName.RHEVH or osname == OSName.OVIRT: Line 150: version, release_name = _parse_node_version('/etc/default/version') Line 151: elif osname == OSName.OVIRT_NGN: > It's fine for me if you want to go this route :) done 1) Line 152: osname, version, release_name = _parse_ngn_version('/etc/os-release') Line 153: elif osname == OSName.DEBIAN: Line 154: version = linecache.getline('/etc/debian_version', 1).strip("\n") Line 155: release_name = "" # Debian just has a version entry -- To view, visit https://gerrit.ovirt.org/57620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17337643cd4e986c09b07137d80da3555161ee70 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
