Marcin Mirecki has posted comments on this change. Change subject: hooks: openstack hook should wait a while for nic activation ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/58917/1/vdsm_hooks/openstacknet/after_vm_start.py File vdsm_hooks/openstacknet/after_vm_start.py: PS1, Line 24: vdscli.connect(vdscli.cannonizeHostPort('0'), True, None) > just call vdscli.connect(). It has some sane heuristics regarding how to co Done Line 26: Line 27: def main(): Line 28: vm_id = os.environ[VM_ID_KEY] Line 29: launch_flags = hooking.load_vm_launch_flags_from_file(vm_id) Line 30: if launch_flags == libvirt.VIR_DOMAIN_START_PAUSED: > this has a bug if the admin asked to start the VM in PAUSED state. this act Done Line 31: time.sleep(OPENSTACK_NIC_WAIT_TIME) Line 32: resume_paused_vm(vm_id) Line 33: Line 34: https://gerrit.ovirt.org/#/c/58917/1/vdsm_hooks/openstacknet/before_device_create.py File vdsm_hooks/openstacknet/before_device_create.py: Line 136: % (vNicId, providerType, pluginType)) Line 137: addOpenstackVnic(domxml, pluginType, vNicId, hasSecurityGroups) Line 138: hooking.write_domxml(domxml) Line 139: if pluginType == PT_OVS: Line 140: flag = libvirt.VIR_DOMAIN_START_PAUSED > we must first READ the lauchflags file (remember it somewhere) and only the Done Line 141: hooking.dump_vm_launch_flags_to_file(os.environ[VM_ID_KEY], flag) Line 142: Line 143: Line 144: def test(ovs, withSecurityGroups): -- To view, visit https://gerrit.ovirt.org/58917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
