Milan Zamazal has posted comments on this change. Change subject: rpc: Log also error codes of RPC calls ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/59234/4/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 514: response_log = "succeeded" Line 515: else: Line 516: response_log = "failed (error %s)" % (error.code,) Line 517: else: Line 518: response_log = "without response" > This does not make sense to me. To me, it looks like a good idea. Line 519: self.log.info("RPC call %s %s in %.2f seconds", Line 520: req.method, response_log, monotonic_time() - start_time) Line 521: Line 522: def _do_serveRequest(self, ctx, req): -- To view, visit https://gerrit.ovirt.org/59234 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I776e667fcfd1a20a9ef5f6c638d6c3d950672314 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
