Petr Horáček has posted comments on this change. Change subject: net tests: Functional tests infrastructure ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/58329/12/tests/network/netfunctestlib.py File tests/network/netfunctestlib.py: Line 200: raise SetupNetworksError(msg) Line 201: return self Line 202: Line 203: def __enter__(self): Line 204: self.post_setup_hook() > meh, sorry, i see now... like you said dear Edy, when this fails, no cleanup is done. Line 205: Line 206: def __exit__(self, type, value, traceback): Line 207: networks_caps = self.vdsm_proxy.netinfo.networks Line 208: NETSETUP = {net: {'remove': True} -- To view, visit https://gerrit.ovirt.org/58329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4645756c575f34cabf9536ef663ffc8009655abb Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
