Francesco Romani has posted comments on this change. Change subject: virt: Improve thread safety of discarding executor workers ......................................................................
Patch Set 11: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/58146/11/lib/vdsm/executor.py File lib/vdsm/executor.py: PS11, Line 229: if task_number != self._task_counter: : return neat! https://gerrit.ovirt.org/#/c/58146/2/lib/vdsm/schedule.py File lib/vdsm/schedule.py: Line 187: Returned when a callable is scheduled. The caller may cancel the call if it Line 188: was not called yet. Line 189: Line 190: This class is thread safe; any thread can cancel a call. Line 191: +1 here. _Could_ be a trivial separate patch and quickly merged. Line 192: Please note that canceling a call works only if the function was not Line 193: invoked yet. But because this happens in different threads, this does not Line 194: guarantee that the callback will not be run after cancel() is called. Line 195: """ -- To view, visit https://gerrit.ovirt.org/58146 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a4cec1a4b3c1e1aa341d90c0e02f46d0b776e9c Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
