Marcin Mirecki has posted comments on this change. Change subject: vdsm: removing txRate and rxRate from code ......................................................................
Patch Set 5: Yes, rx/tx rate are still used on the engine. But they are not received from vdsm anymore, being instead calculated using other data. Patch: https://gerrit.ovirt.org/#/c/59508/ removes the extracting from vdsm data. The way we come up with rx/tx rate now is we calculate it in: NetworkStatisticsBuilder.updateExistingInterfaceStatistics (line 52). and use this value further on in the code. There was already a discussion on a related topic: https://gerrit.ovirt.org/#/c/59508/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java -- To view, visit https://gerrit.ovirt.org/59544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6466de88f0228ac3496b4642d34f5eb7b281afa Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
