Piotr Kliczewski has posted comments on this change.

Change subject: yml: parameter type fixes for StoragePool.spmStart
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/59704/1/tests/vdsmapi_test.py
File tests/vdsmapi_test.py:

Line 580: 
Line 581:         _schema.schema().verify_retval(
Line 582:             vdsmapi.MethodRep('Host', 'hostdevListByCaps'), ret)
Line 583: 
Line 584:     def test_start_spm(self):
> This test is harmful.
As in previous patch.
Line 585:         params = {u'prevLver': u'-1',
Line 586:                   u'enableScsiFencing': u'false',
Line 587:                   u'storagepoolID': 
u'636d9c59-f7ba-4115-87a1-44d6563a9610',
Line 588:                   u'prevID': -1,


-- 
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to