Francesco Romani has posted comments on this change. Change subject: hostdev: move pci device code to separate class ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/57956/8//COMMIT_MSG Commit Message: PS8, Line 35: [2] This is true only because reattach, in it's current version, does : more then just reattach the device. It modifies the permissions on the : udev device by creating udev rule. The rule should be removed. The : removal process must be split from reattach call. > can we fix this before than this series (which I still like, btw)? it seems I forgot about https://gerrit.ovirt.org/#/c/59042/5 so my question switches to: can we have 59042 first? -- To view, visit https://gerrit.ovirt.org/57956 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bceb93c2434ff827406bbf4ee0af30f5726f6af Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Tomas Golembiovsky <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
