Piotr Kliczewski has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
......................................................................


Patch Set 11:

(2 comments)

https://gerrit.ovirt.org/#/c/35181/11/contrib/jsonrpc
File contrib/jsonrpc:

Line 38: 
Line 39: For invokinng methods with many or complex parameters, you can read the
Line 40: parameters from a file:
Line 41: 
Line 42:     # jsonrpc VM.create -f vm-create
> could you provide an example how does a complex input like this would look 
File content should look the same as params provided in std input like below. 
Will update here.
Line 43:     ...
Line 44: 
Line 45: It is also possible to read parameters from standard input, creating 
complex
Line 46: parameters interactively:


Line 111: 
Line 112: def option_parser():
Line 113:     parser = argparse.ArgumentParser()
Line 114:     parser.add_argument('-a', '--host', dest="host", 
default="localhost",
Line 115:                         help='host address (default localhost)')
> can you contact a host with ssl=True (which is the default, common installa
Actually we use ssl=True by default and we use cert location as defined in 
constants. Do you suggest that user should be able to provide cert location?
Line 116:     parser.add_argument('method', help='remote method name')
Line 117:     parser.add_argument('-f', '--file', dest='file',
Line 118:                         help="read method parameters from json file. 
Set to"
Line 119:                              " '-' to read from standard input")


-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ov...@midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to