Sandro Bonazzola has posted comments on this change. Change subject: readme: Simplify installation instructions ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/48713/1//COMMIT_MSG Commit Message: Line 6: Line 7: readme: Simplify installation instructions Line 8: Line 9: We need to run ./autogen.sh, and configure is not needed usually, no Line 10: need to make it look more complex then it is. then -> than Line 11: Line 12: The --force flag is a good idea in the first run, and it is better to Line 13: show how to get more help than to duplicate the help in the readme. Line 14: https://gerrit.ovirt.org/#/c/48713/1/README File README: Line 19: The Vdsm service can be used by following the standard autotools Line 20: installation process, documented in the INSTALL file. As a quick Line 21: start you can do Line 22: Line 23: ./autogen.sh --system > So the current instaructions are good for users, and my version is for deve > So the current instaructions are good for users, and my version is for > developers? current instructions are good for those who download the released tarball and build from it. Your version is good for those who clone git repo and build from it. > Do you think we should keep both in the readme, or only the user version? I think you can keep both of them. Line 24: make Line 25: sudo make install Line 26: Line 27: In order to start vdsm at first time, please perform: -- To view, visit https://gerrit.ovirt.org/48713 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I868a3de7991af5d9f39e9e489bf23587b13b1e58 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
