Nir Soffer has posted comments on this change. Change subject: oop: Fix and simplify oop lifetime ......................................................................
Patch Set 16: (1 comment) https://gerrit.ovirt.org/#/c/58622/16/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: Line 6857: name: image Line 6858: type: *UUID Line 6859: Line 6860: - description: Volume storage domain mountpoint (for internal use Line 6861: only). > Current code would warn if any param is not documented. I am still not sure This parameter is used only by virt, calling storage api directoy via API.py, so the bridge is not involved in this call. Engine will get this value in the return value, but we don't have to document it. This seems like the best way, so we don't have to make this value public. Client should never use undocumented apis. I'll remove the schema change in the next version. Line 6862: name: mountpoint Line 6863: type: string Line 6864: added: '4.1' Line 6865: -- To view, visit https://gerrit.ovirt.org/58622 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a625efd04d6f7b8656aaeece216043836f4dec5 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
